◐ Shell
clean mode source ↗

gh-146102: Fix type slot_bf_getbuffer() error handling by vstinner · Pull Request #151346 · python/cpython

@vstinner

@vstinner vstinner commented

Jun 11, 2026

edited by bedevere-app Bot

Loading

Call PyBuffer_Release() if PyObject_GC_New() fails.

Fix also bytes_join(): only call Py_DECREF(item) after formatting the
error message which uses item.

@vstinner

Tests / Windows / Build and test (x64, tail-call) (pull_request): Failing after 10m

It's a test_logging test which fails randomly: I reported the bug to issue gh-84649.

FAIL: test_rollover_at_midnight (test.test_logging.TimedRotatingFileHandlerTest.test_rollover_at_midnight)

cmaloney

serhiy-storchaka

philthompson10 pushed a commit to philthompson10/cpython that referenced this pull request

Jun 17, 2026
…151346)

Call PyBuffer_Release() if PyObject_GC_New() fails.

Fix also bytes_join(): only call Py_DECREF(item) after formatting the
error message which uses item.