gh-146102: Don't clear exception on success in odictobject.c by vstinner · Pull Request #151347 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Conversation
Member
Calling PyErr_Clear() on success can mask a pending exception. Replace it with an assertion checking that no exception is set.
Calling PyErr_Clear() on success can mask a pending exception. Replace it with an assertion checking that no exception is set.
vstinner
added
the
skip news
label
bedevere-app
Bot
added
the
awaiting core review
label
vstinner
commented
Jun 11, 2026
vstinner commented
Member Author
See the report: https://gist.github.com/devdanzin/9015c335e324a94ea06932bdd643a7dc.
bedevere-app
Bot
mentioned this pull request
serhiy-storchaka
approved these changes
bedevere-app
Bot
added
awaiting merge
and removed
awaiting core review
labels
vstinner
deleted the
odict
branch
bedevere-app
Bot
removed
the
awaiting merge
label
philthompson10 pushed a commit to philthompson10/cpython that referenced this pull request
…ython#151347) Calling PyErr_Clear() on success can mask a pending exception. Replace it with an assertion checking that no exception is set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment