◐ Shell
clean mode source ↗

bpo-37947: Avoid double-decrement in symtable recursion counting by ncoghlan · Pull Request #15593 · python/cpython

@ncoghlan

pablogsal

@ncoghlan ncoghlan deleted the bpo-37947-symtable-recursion-counting branch

August 29, 2019 13:26

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 29, 2019
…honGH-15593)

With `symtable_visit_expr` now correctly adjusting the recursion depth for named
expressions, `symtable_handle_namedexpr` should be leaving it alone.

Also adds a new check to `PySymtable_BuildObject` that raises `SystemError`
if a successful first symbol analysis pass fails to keep the stack depth
accounting clean.
(cherry picked from commit 0614523)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>

miss-islington added a commit that referenced this pull request

Aug 29, 2019
…15593)

With `symtable_visit_expr` now correctly adjusting the recursion depth for named
expressions, `symtable_handle_namedexpr` should be leaving it alone.

Also adds a new check to `PySymtable_BuildObject` that raises `SystemError`
if a successful first symbol analysis pass fails to keep the stack depth
accounting clean.
(cherry picked from commit 0614523)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>

lisroach pushed a commit to lisroach/cpython that referenced this pull request

Sep 10, 2019
…honGH-15593)

With `symtable_visit_expr` now correctly adjusting the recursion depth for named
expressions, `symtable_handle_namedexpr` should be leaving it alone.

Also adds a new check to `PySymtable_BuildObject` that raises `SystemError`
if a successful first symbol analysis pass fails to keep the stack depth
accounting clean.

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Jan 14, 2020
…honGH-15593)

With `symtable_visit_expr` now correctly adjusting the recursion depth for named
expressions, `symtable_handle_namedexpr` should be leaving it alone.

Also adds a new check to `PySymtable_BuildObject` that raises `SystemError`
if a successful first symbol analysis pass fails to keep the stack depth
accounting clean.

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request

Jul 20, 2020
…honGH-15593)

With `symtable_visit_expr` now correctly adjusting the recursion depth for named
expressions, `symtable_handle_namedexpr` should be leaving it alone.

Also adds a new check to `PySymtable_BuildObject` that raises `SystemError`
if a successful first symbol analysis pass fails to keep the stack depth
accounting clean.