[3.8] bpo-38006: Avoid closure in weakref.WeakValueDictionary (GH-15641) by miss-islington · Pull Request #15787 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Merged
Conversation
Contributor
weakref.WeakValueDictionary defines a local remove() function used as
callback for weak references. This function was created with a
closure. Modify the implementation to avoid the closure.
(cherry picked from commit a2af05a)
Co-authored-by: Victor Stinner vstinner@redhat.com
weakref.WeakValueDictionary defines a local remove() function used as callback for weak references. This function was created with a closure. Modify the implementation to avoid the closure. (cherry picked from commit a2af05a) Co-authored-by: Victor Stinner <vstinner@redhat.com>
vstinner
approved these changes
vstinner
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good bot.
miss-islington
commented
Sep 9, 2019
miss-islington commented
Contributor Author
@vstinner: Status check is done, and it's a success ✅ .
78d15fa
into
python:3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
