◐ Shell
clean mode source ↗

[3.8] bpo-37531: Enhance regrtest multiprocess timeout (GH-15345) by vstinner · Pull Request #15871 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

vstinner

merged 1 commit into

python:3.8from

vstinner:regrtest38

Sep 10, 2019

Merged

Conversation

@vstinner

@vstinner vstinner commented

Sep 10, 2019

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

  • Write a message when killing a worker process
  • Put a timeout on the second popen.communicate() call
    (after killing the process)
  • Put a timeout on popen.wait() call
  • Catch popen.kill() and popen.wait() exceptions

(cherry picked from commit de2d9ee)

https://bugs.python.org/issue37531

* Write a message when killing a worker process
* Put a timeout on the second popen.communicate() call
  (after killing the process)
* Put a timeout on popen.wait() call
* Catch popen.kill() and popen.wait() exceptions

(cherry picked from commit de2d9ee)

@bedevere-bot bedevere-bot added the tests

Tests in the Lib/test dir

label

Sep 10, 2019

@vstinner vstinner merged commit d42a4fd into python:3.8

Sep 10, 2019

@vstinner vstinner deleted the regrtest38 branch

September 10, 2019 15:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot