◐ Shell
clean mode source ↗

bpo-33166: Change os.cpu_count to return active (real) processors by zooba · Pull Request #15949 · python/cpython

zooba

Conversation

@zooba

Note that I added the prototype rather than changing the Windows version in pyconfig.h. This is so it's safe to backport to 3.8.

In a later PR I'll update the API version.

zware

@bedevere-bot

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@zooba

I don't want to backport the WINNT_VER change because we have so much stuff that tries to auto-detect macros, and that may introduce new macros. It's a little late in the release cycle for that.

@zooba

I have made the requested changes; please review again

Ping @zware

zware

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zooba zooba mentioned this pull request

Sep 11, 2019

@miss-islington

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 11, 2019 
…thonGH-15949)

(cherry picked from commit aa92927)

Co-authored-by: Steve Dower <steve.dower@python.org>

@bedevere-bot

miss-islington added a commit that referenced this pull request

Sep 11, 2019 
…-15949)

(cherry picked from commit aa92927)

Co-authored-by: Steve Dower <steve.dower@python.org>

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Sep 12, 2019

Labels