◐ Shell
clean mode source ↗

bpo-38187: Fix a refleak in Tools/c-analyzer. by ericsnowcurrently · Pull Request #16304 · python/cpython

ericsnowcurrently

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented

Sep 20, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

The "Slot" helper (descriptor) is leaking references due to its caching mechanism. The PR includes a partial fix to Slot, but also adds Variable.storage to replace the problematic use of Slot.

https://bugs.python.org/issue38187

@ericsnowcurrently ericsnowcurrently merged commit 6693f73 into python:master

Sep 27, 2019

@ericsnowcurrently ericsnowcurrently deleted the fix-38187-Slot-descriptor-refleak branch

September 27, 2019 14:53

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request

Dec 5, 2019 
The "Slot" helper (descriptor) is leaking references due to its caching mechanism. The change includes a partial fix to Slot, but also adds Variable.storage to replace the problematic use of Slot.

https://bugs.python.org/issue38187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 left review comments

@pablogsal pablogsal Awaiting requested review from pablogsal

+1 more reviewer

@aeros aeros aeros left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericsnowcurrently @1st1 @aeros @the-knights-who-say-ni @bedevere-bot