◐ Shell
clean mode source ↗

bpo-38249: Expand Py_UNREACHABLE() to __builtin_unreachable() in the release mode. by serhiy-storchaka · Pull Request #16329 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented

Sep 22, 2019

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

Comment thread

Include/pymacro.h Outdated

Comment thread

Modules/_tracemalloc.c Outdated

Comment thread

Python/pytime.c Outdated

Comment thread

Python/pytime.c Outdated

Comment thread

Python/pytime.c Outdated

Comment thread

Python/pytime.c Outdated

@serhiy-storchaka

Copy link Copy Markdown

Member Author

Thank you for your suggestions Victor and Ammar!

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

With the updated doc, it is easier for me to tell that the PR is consistent :-)

@serhiy-storchaka serhiy-storchaka merged commit eebaa9b into python:master

Mar 9, 2020

@serhiy-storchaka serhiy-storchaka deleted the Py_UNREACHABLE-builtin_unreachable branch

March 9, 2020 18:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ammaraskar ammaraskar ammaraskar left review comments

@vstinner vstinner vstinner approved these changes

@abalkin abalkin Awaiting requested review from abalkin

@pganssle pganssle Awaiting requested review from pganssle

Assignees

No one assigned

Labels

performance

Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @vstinner @ammaraskar @the-knights-who-say-ni @bedevere-bot