bpo-38249: Expand Py_UNREACHABLE() to __builtin_unreachable() in the release mode. by serhiy-storchaka · Pull Request #16329 · python/cpython
Conversation
Member
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
ammaraskar
reviewed
Include/pymacro.h Outdated
serhiy-storchaka added 3 commits
serhiy-storchaka
requested review from
abalkin and
pganssle
as code owners
vstinner
reviewed
Include/pymacro.h Outdated
Modules/_tracemalloc.c Outdated
Python/pytime.c Outdated
Python/pytime.c Outdated
Python/pytime.c Outdated
Python/pytime.c Outdated
serhiy-storchaka and others added 6 commits
Co-Authored-By: Victor Stinner <vstinner@python.org>
…y-storchaka/cpython into Py_UNREACHABLE-builtin_unreachable
serhiy-storchaka
commented
Mar 9, 2020
serhiy-storchaka commented
Member Author
Thank you for your suggestions Victor and Ammar!
vstinner
approved these changes
vstinner
left a comment
vstinner
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
With the updated doc, it is easier for me to tell that the PR is consistent :-)
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
serhiy-storchaka
merged commit
eebaa9b
into
python:master
bedevere-bot
removed
the
awaiting merge
label
serhiy-storchaka
deleted the
Py_UNREACHABLE-builtin_unreachable
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment