◐ Shell
clean mode source ↗

bpo-38270: Check for hash digest algorithms and avoid MD5 by tiran · Pull Request #16382 · python/cpython

added 4 commits

September 25, 2019 12:11
The new test helper requires_hashdigest() marks tests that require a
specific hashlib algorithm. If the algorithm is not available or blocked
by a security policy, the test case is skipped.

Signed-off-by: Christian Heimes <christian@python.org>
test_hmac now uses SHA256 instead of MD5 for default constructor tests.
All tests now use requires_hashdigest(), too.

Signed-off-by: Christian Heimes <christian@python.org>
Signed-off-by: Christian Heimes <christian@python.org>
Some test cases for imaplib, poplib, smptlib, and urllib2 require MD5 to
perform digest auth / CRAM-MD5 auth testing. These tests are now marked
as requiring MD5 and skipped when MD5 is not available.

Signed-off-by: Christian Heimes <christian@python.org>

vstinner

Signed-off-by: Christian Heimes <christian@python.org>

vstinner

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 25, 2019
…6382)

Make it easier to run and test Python on systems with restrict crypto policies:

* add requires_hashdigest to test.support to check if a hash digest algorithm is available and working
* avoid MD5 in test_hmac
* replace MD5 with SHA256 in test_tarfile
* mark network tests that require MD5 for MD5-based digest auth or CRAM-MD5

https://bugs.python.org/issue38270
(cherry picked from commit c64a1a6)

Co-authored-by: Christian Heimes <christian@python.org>

miss-islington added a commit that referenced this pull request

Sep 25, 2019
…6382) (GH-16393)

Make it easier to run and test Python on systems with restrict crypto policies:

* add requires_hashdigest to test.support to check if a hash digest algorithm is available and working
* avoid MD5 in test_hmac
* replace MD5 with SHA256 in test_tarfile
* mark network tests that require MD5 for MD5-based digest auth or CRAM-MD5


https://bugs.python.org/issue38270
(cherry picked from commit c64a1a6)


Co-authored-by: Christian Heimes <christian@python.org>


https://bugs.python.org/issue38270



Automerge-Triggered-By: @tiran

stratakis pushed a commit to stratakis/cpython that referenced this pull request

Dec 2, 2019
…onGH-16382) (pythonGH-16393)

Make it easier to run and test Python on systems with restrict crypto policies:

* add requires_hashdigest to test.support to check if a hash digest algorithm is available and working
* avoid MD5 in test_hmac
* replace MD5 with SHA256 in test_tarfile
* mark network tests that require MD5 for MD5-based digest auth or CRAM-MD5

https://bugs.python.org/issue38270
(cherry picked from commit c64a1a6)

Co-authored-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue38270

Automerge-Triggered-By: @tiran

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request

Dec 5, 2019
…6382)

Make it easier to run and test Python on systems with restrict crypto policies:

* add requires_hashdigest to test.support to check if a hash digest algorithm is available and working
* avoid MD5 in test_hmac
* replace MD5 with SHA256 in test_tarfile
* mark network tests that require MD5 for MD5-based digest auth or CRAM-MD5


https://bugs.python.org/issue38270

stratakis pushed a commit to stratakis/cpython that referenced this pull request

May 5, 2020
…onGH-16382) (pythonGH-16393)

Make it easier to run and test Python on systems with restrict crypto policies:

* add requires_hashdigest to test.support to check if a hash digest algorithm is available and working
* avoid MD5 in test_hmac
* replace MD5 with SHA256 in test_tarfile
* mark network tests that require MD5 for MD5-based digest auth or CRAM-MD5

https://bugs.python.org/issue38270
(cherry picked from commit c64a1a6)

Co-authored-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue38270

Automerge-Triggered-By: @tiran

@tiran tiran mentioned this pull request

Sep 9, 2022