◐ Shell
clean mode source ↗

[3.8] bpo-36670: regrtest bug fixes (GH-16537) by miss-islington · Pull Request #16538 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

  • Fix TestWorkerProcess.repr(): start_time is only valid
    if _popen is not None.
  • Fix _kill(): don't set _killed to True if _popen is None.
  • _run_process(): only set _killed to False after calling
    run_test_in_subprocess().
    (cherry picked from commit 2ea71a0)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue36670

 
* Fix TestWorkerProcess.__repr__(): start_time is only valid
  if _popen is not None.
* Fix _kill(): don't set _killed to True if _popen is None.
* _run_process(): only set _killed to False after calling
  run_test_in_subprocess().
(cherry picked from commit 2ea71a0)

Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment

@miss-islington

@vstinner: Status check is done, and it's a success ✅ .

Labels