◐ Shell
clean mode source ↗

bpo-38396: dump(node) instead of repr(node) on ast.literal_eval by isidentical · Pull Request #16620 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@isidentical

@isidentical isidentical commented

Oct 7, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please try to write a test?

@isidentical

isidentical commented

Dec 14, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member Author

bpo-38396 resolved as duplicate of bpo-32888 and #340 is about fixing it. It has a slightly different approach but resolves the same problem so I think this PR can be closed.

@vstinner

Copy link Copy Markdown

Member

Oh, @ilevkivskyi seems to be against this PR, so I close it: https://bugs.python.org/issue38396#msg354132 I agree that PR #340 should produce shorter and better error message.

@vstinner vstinner closed this

Dec 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isidentical @vstinner @the-knights-who-say-ni @bedevere-bot