bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing of URLs (GH-15522)" by maxking · Pull Request #16724 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could a unit test been added to verify (current and future) correct operation on a file name with ; and may be other tricky symbols legit to be in a file name but not a URL?
@yarikoptic This is just reverting the previous change which caused the regression so release managers can pick this up for the final releases.
Fixes and more unit tests should be best added in the next PR which should fix the original issue and the issue raised in bpo-38449.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except it needs a news (blurb) entry about the revert since it introduces a change between 3.8.0rc1/3.7.5rc1 and 3.8.0final/3.7.5final.
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
I have made the requested changes; please review again
Thanks for making the requested changes!
@ned-deily: please review the changes made to this pull request.
Thanks @maxking for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
Sorry @maxking, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 19a3d873005e5730eeabdc394c961e93f2ec02f0 3.8
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request