◐ Shell
clean mode source ↗

Adding missing acknowledgement by Kentzo · Pull Request #17130 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Kentzo

@Kentzo Kentzo commented

Nov 12, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Due to:
[bpo-26467](#9296): large chunk of the "based on" Apache 2.0 licensed code
[bpo-29302](#4790)

 
bpo-26467: large chunk of the "based on" code
bpo-29302

@brandtbucher brandtbucher left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!
Kentzo reacted with thumbs up emoji

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @Kentzo for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

Copy link Copy Markdown

GH-17138 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request

Nov 13, 2019 
Contributions on bpo-26467 and bpo-29302.
(cherry picked from commit d6d6e2a)

Co-authored-by: Ilya Kulakov <kulakov.ilya@gmail.com>

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request

Dec 5, 2019 
Contributions on bpo-26467 and bpo-29302.

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request

Jan 31, 2020 
Contributions on bpo-26467 and bpo-29302.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Kentzo @miss-islington @bedevere-bot @brandtbucher @benjaminp @the-knights-who-say-ni