◐ Shell
clean mode source ↗

bpo-38997: Revert commits 6e157fa and 5df5dbe by pablogsal · Pull Request #17509 · python/cpython

pablogsal

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@pablogsal

@pablogsal pablogsal commented

Dec 8, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@pablogsal pablogsal requested a review from vstinner

December 8, 2019 15:37

@pablogsal pablogsal changed the title Revert commits 6e157fa and 5df5dbe bpo-38997: Revert commits 6e157fa and 5df5dbe

Dec 8, 2019

@vstinner

vstinner commented

Dec 8, 2019

Copy link Copy Markdown

Member

My PR 17512 fix https://bugs.python.org/issue38997 and so I would prefer to merge my fix for the ref leak (which is not strictly a regression in your look into the details...), rather than a simple revert.

@vstinner

vstinner commented

Dec 8, 2019

Copy link Copy Markdown

Member

I confirm that my PR 17512 fix https://bugs.python.org/issue38997 so I close this PR. Thanks for preparing a revert Pablo ;-)
https://bugs.python.org/issue38997#msg358032

@vstinner vstinner closed this

Dec 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @vstinner @the-knights-who-say-ni @bedevere-bot