◐ Shell
clean mode source ↗

[3.7] bpo-38546: Fix concurrent.futures test_ressources_gced_in_workers() (GH-17652) by miss-islington · Pull Request #17654 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

Dec 18, 2019

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Fix test_ressources_gced_in_workers() of test_concurrent_futures:
explicitly stop the manager to prevent leaking a child process
running in the background after the test completes.
(cherry picked from commit 673c393)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue38546

…ythonGH-17652)

Fix test_ressources_gced_in_workers() of test_concurrent_futures:
explicitly stop the manager to prevent leaking a child process
running in the background after the test completes.
(cherry picked from commit 673c393)

Co-authored-by: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a failure ❌ .

@vstinner vstinner closed this

Dec 18, 2019

@miss-islington miss-islington deleted the backport-673c393-3.7 branch

December 18, 2019 16:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

awaiting merge tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot