bpo-12159: document sys.maxsize limit in len() function reference by Zac-HD · Pull Request #17934 · python/cpython
I think that this is a good addition to the documentation, but the example with range is weird. Maybe you mean that big ranges, such as range(10 ** 100) will be too big. That isn't clear from your text.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| on inputs larger than :data:`sys.maxsize`, such as :class:`range`. | |
| on lengths larger than :data:`sys.maxsize`. |
I don't understand the "such as range()" part. len(range(5)) returns 5, it doesn't fail with overflow?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've clarified that this is for cases such as range(2 ** 64).
BPO-12159: document
bpo-12159: document sys.maxsize limit in len() function referencesys.maxsize limit in function reference for len()
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since this has been brought up multiple times, I think it's best to document it, especially since __len__ had a note added in the past. Thanks for the patch, @Zac-HD!
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
I have made the requested changes; please review again
