bpo-39388: IDLE: Fix bug when cancelling out of configdialog by csabella · Pull Request #18068 · python/cpython
bpo-39388: Fix bug when cancelling out of configdialog
bpo-39388: IDLE: Fix bug when cancelling out of configdialog
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A 2nd button bug not caught by missing tests. We wrote changes.clear to be called at this spot. (It is not called anywhere else.) I will add a test that changes is cleared and add news items.
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
sthagen added a commit to sthagen/python-cpython that referenced this pull request
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (pythonGH-18068)
miss-islington added a commit that referenced this pull request
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit d0d9fa8) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit d0d9fa8) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
I had some additional test for configdialog in GH-3592 and I rebased it last week. It's not all the missing tests.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request
…H-18068) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>