◐ Shell
clean mode source ↗

bpo-39128: Added happy_eyeballs_delay, interleave to function signature by idomic · Pull Request #18315 · python/cpython

idomic

Conversation

@idomic

@asvetlov Do I need news here? it's only documentation.
Would you also like to include a paragraph on the algorithm after the changeset, Changed in version 3.5: Added support for SSL/TLS in ProactorEventLoop. ?

@JulienPalard JulienPalard changed the title 39128 - Added happy_eyeballs_delay, interleave to function signature bpo-39128: Added happy_eyeballs_delay, interleave to function signature

Feb 6, 2020

@JulienPalard

Do I need news here?

Not needed, it's only documentation.

What about adding a:

.. versionchanged:: 3.8
   Added the *happy_eyeballs_delay* and *interleave* parameters.

@idomic

.. versionchanged:: 3.8
Added the happy_eyeballs_delay and interleave parameters.

I agree

Do I need news here?

Not needed, it's only documentation.

What about adding a:

.. versionchanged:: 3.8
   Added the *happy_eyeballs_delay* and *interleave* parameters.

Done.

@miss-islington

Thanks @idomic for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 10, 2020

miss-islington added a commit that referenced this pull request

Feb 10, 2020 
…re (GH-18315)

(cherry picked from commit 5305cc9)

Co-authored-by: idomic <michael.ido@gmail.com>

Labels