Doc nits for bpo-16500 by pitrou · Pull Request #1841 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyOS_AfterFork() also is mentioned in Doc/c-api/init.rst.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
But maybe Doc/c-api/init.rst needs more updates.
| into Python) may result in a deadlock by one of Python's internal locks | ||
| being held by a thread that is defunct after the fork. | ||
| :c:func:`PyOS_AfterFork` tries to reset the necessary locks, but is not | ||
| :c:func:`PyOS_AfterFork_Child` tries to reset the necessary locks, but is not |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth to update the first part of this paragraph according to new API?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which part exactly?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"there is no way to inform Python of additional (non-Python) locks that need to be acquired before or reset after a fork" and mentioning pthread_atfork.
