bpo-39573: Fix bad copy-paste in Py_SET_SIZE. by brandtbucher · Pull Request #18496 · python/cpython

the-knights-who-say-ni

brandtbucher commented
Feb 13, 2020
•

edited by bedevere-bot

Loading

Copy link

Copy Markdown

Member

@vstinner

https://bugs.python.org/issue39573

refcnt -> size

90df6ea

the-knights-who-say-ni added the CLA signed label

Feb 13, 2020

brandtbucher requested a review from vstinner

February 13, 2020 01:43

bedevere-bot added the awaiting review label

Feb 13, 2020

brandtbucher added the skip news label

Feb 13, 2020

vstinner mentioned this pull request

Feb 13, 2020

bpo-39573: Add Py_IS_TYPE macro #18488

Merged

vstinner reviewed Feb 13, 2020

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed a typo in Py_SET_SIZE() doc:
https://docs.python.org/dev/c-api/structures.html#c.Py_SET_SIZE

"Set the object o size of size." => "Set ... to size."

Would you mind to also fix it, please?

to -> of

6d4ee95

codecov Bot commented
Feb 13, 2020

Copy link

Copy Markdown

Codecov Report

Merging #18496 into master will increase coverage by 1.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #18496       +/-   ##
===========================================
+ Coverage   82.10%   83.20%    +1.09%     
===========================================
  Files        1958     1571      -387     
  Lines      589576   414668   -174908     
  Branches    44449    44450        +1     
===========================================
- Hits       484095   345007   -139088     
+ Misses      95833    60017    -35816     
+ Partials     9648     9644        -4

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	`30.00% <0.00%> (-65.00%)`	⬇️
Lib/distutils/command/bdist_rpm.py	`7.63% <0.00%> (-56.88%)`	⬇️
Lib/test/test_urllib2net.py	`76.92% <0.00%> (-13.85%)`	⬇️
Lib/test/test_smtpnet.py	`78.57% <0.00%> (-7.15%)`	⬇️
Lib/ftplib.py	`63.85% <0.00%> (-6.06%)`	⬇️
Lib/test/test_ftplib.py	`87.11% <0.00%> (-4.72%)`	⬇️
Tools/scripts/db2pickle.py	`17.82% <0.00%> (-3.97%)`	⬇️
Tools/scripts/pickle2db.py	`16.98% <0.00%> (-3.78%)`	⬇️
Lib/test/test_socket.py	`71.94% <0.00%> (-3.77%)`	⬇️
Lib/test/test_asyncio/test_base_events.py	`91.84% <0.00%> (-3.30%)`	⬇️
... and 442 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3aee6...6d4ee95. Read the comment docs.