bpo-30502: Fix handling of long oids by tiran · Pull Request #1852 · python/cpython
Signed-off-by: Christian Heimes <christian@python.org>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I suggest the patch that don't duplicate the code (see on the tracker).
| PyErr_NoMemory(); | ||
| goto fail; | ||
| } | ||
| buflen = OBJ_obj2txt(namebuf, buflen + 1, name, 0); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need that the new buflen is equal to the previous buflen?
An alternate patch is provided as #2909.
Closing in favor of #2909.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters