[workflow] Use gcc matcher to make warnings prominent by ammaraskar · Pull Request #18567 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Merged
Conversation
Member
This makes warnings and errors from the compiler very prominent so this should help prevent warnings from sneaking into the code base and catch them in review.
You can see a demo of this in action here: https://github.com/ammaraskar/cpython/pull/16/files#diff-4d35cf8992b795c5e97e9c8b6167cb34
or in screenshot form:
(This PR is sort of a mirror to #18532 but for the linux builds.)
Codecov Report
Merging #18567 into master will decrease coverage by
0.08%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #18567 +/- ## ========================================== - Coverage 82.15% 82.06% -0.09% ========================================== Files 1958 1955 -3 Lines 589837 584012 -5825 Branches 44458 44458 ========================================== - Hits 484560 479289 -5271 + Misses 95636 95101 -535 + Partials 9641 9622 -19
| Impacted Files | Coverage Δ | |
|---|---|---|
| Lib/distutils/tests/test_bdist_rpm.py | 30.00% <0.00%> (-65.00%) |
⬇️ |
| Lib/distutils/command/bdist_rpm.py | 7.63% <0.00%> (-56.88%) |
⬇️ |
| Modules/_decimal/libmpdec/umodarith.h | 80.76% <0.00%> (-19.24%) |
⬇️ |
| Lib/test/test_urllib2net.py | 76.92% <0.00%> (-13.85%) |
⬇️ |
| Lib/test/test_smtpnet.py | 78.57% <0.00%> (-12.86%) |
⬇️ |
| Lib/ftplib.py | 63.85% <0.00%> (-6.06%) |
⬇️ |
| Lib/test/test_ftplib.py | 87.11% <0.00%> (-4.72%) |
⬇️ |
| Lib/dbm/__init__.py | 66.66% <0.00%> (-4.45%) |
⬇️ |
| Tools/scripts/db2pickle.py | 17.82% <0.00%> (-3.97%) |
⬇️ |
| Lib/test/test_socket.py | 71.94% <0.00%> (-3.87%) |
⬇️ |
| ... and 318 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update f2ee21d...0098272. Read the comment docs.
0098272 to
499adbb
Compare
ammaraskar
commented
Jun 4, 2020
ammaraskar commented
Member Author
(closing and re-opening to re-run CI)
499adbb to
d1d1dd9
Compare
ammaraskar
commented
Jun 4, 2020
ammaraskar commented
Member Author
Ping @pablogsal @zware
Looks like there's no gcc warnings currently so this shouldn't pop up on any existing PRs but it would have caught the issue on #20590
5552850
into
python:master
pablogsal
commented
Jun 6, 2020
pablogsal commented
Member
Thanks for working on this @ammaraskar :) 🎉
zware pushed a commit that referenced this pull request
This makes warnings and errors from the compiler very prominent so this should help prevent warnings from sneaking into the code base and catch them in review. See https://discuss.python.org/t/using-github-problem-matchers-to-catch-warnings-early/4254 for more details You can see a demo of this in action here: https://github.com/ammaraskar/cpython/pull/15/files#diff-9ba2eeca0f254ece0a9df4d7cb68e870 GCC and Sphinx matchers have previously been added in GH-18567 and GH-20325, respectively.
adorilson pushed a commit to adorilson/cpython that referenced this pull request
…H-18532) This makes warnings and errors from the compiler very prominent so this should help prevent warnings from sneaking into the code base and catch them in review. See https://discuss.python.org/t/using-github-problem-matchers-to-catch-warnings-early/4254 for more details You can see a demo of this in action here: https://github.com/ammaraskar/cpython/pull/15/files#diff-9ba2eeca0f254ece0a9df4d7cb68e870 GCC and Sphinx matchers have previously been added in pythonGH-18567 and pythonGH-20325, respectively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
