bpo-39683: 2to3 fix_exitfunc suggests duplicated import of atexit module by phsilva · Pull Request #18654 · python/cpython
Conversation
Contributor
2to3 fix for sys.exitfunc adds multiple imports when sys.exitfunc
is present multiple times.
This patch adds a check for already existing 'import atexit' and
do not add multiple imports.
Codecov Report
Merging #18654 into master will increase coverage by
1.06%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #18654 +/- ## =========================================== + Coverage 82.06% 83.13% +1.06% =========================================== Files 1956 1571 -385 Lines 589514 414887 -174627 Branches 44464 44465 +1 =========================================== - Hits 483809 344928 -138881 + Misses 96052 60339 -35713 + Partials 9653 9620 -33
| Impacted Files | Coverage Δ | |
|---|---|---|
| Lib/distutils/tests/test_bdist_rpm.py | 30.00% <0.00%> (-65.00%) |
⬇️ |
| Lib/distutils/command/bdist_rpm.py | 7.63% <0.00%> (-56.88%) |
⬇️ |
| Lib/test/test_urllib2net.py | 76.92% <0.00%> (-13.85%) |
⬇️ |
| Lib/test/test_smtpnet.py | 78.57% <0.00%> (-7.15%) |
⬇️ |
| Lib/ftplib.py | 63.85% <0.00%> (-6.06%) |
⬇️ |
| Lib/test/test_ftplib.py | 87.11% <0.00%> (-4.72%) |
⬇️ |
| Tools/scripts/db2pickle.py | 17.82% <0.00%> (-3.97%) |
⬇️ |
| Tools/scripts/pickle2db.py | 16.98% <0.00%> (-3.78%) |
⬇️ |
| Lib/test/test_socket.py | 71.94% <0.00%> (-3.77%) |
⬇️ |
| Lib/test/test_asyncio/test_base_events.py | 91.84% <0.00%> (-3.30%) |
⬇️ |
| ... and 428 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update eb8ac57...88488c3. Read the comment docs.
d9163a5 to
88488c3
Compare
isidentical
reviewed
Misc/NEWS.d/next/Tools-Demos/2020-02-25-01-08-58.bpo-39683.-fbPik.rst Outdated
2to3 fix for sys.exitfunc adds multiple import when sys.exitfunc is present multiple times. This patch adds a check for already existing 'import atexit' and do not add multiple imports.
88488c3 to
1844260
Compare
isidentical
approved these changes
Member
Closed under bpo-45544.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
