◐ Shell
clean mode source ↗

bpo-39674: Revert "bpo-37330: open() no longer accept 'U' in file mode (GH-16959)" by vstinner · Pull Request #18767 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

vstinner

merged 1 commit into

python:masterfrom

vstinner:revert_u_mode

Mar 4, 2020

Conversation

@vstinner

@vstinner vstinner commented

Mar 3, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

This reverts commit e471e72.

The mode will be removed from Python 3.10.

https://bugs.python.org/issue39674

 
GH-16959)"

This reverts commit e471e72.

The mode will be removed from Python 3.10.

@vstinner

vstinner commented

Mar 3, 2020

Copy link Copy Markdown

Member Author

@tirkarthi @serhiy-storchaka: You approved PR #16959. Would you mind to review this revert? See https://bugs.python.org/issue39674 for the rationale.

@tirkarthi tirkarthi left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since it seems to be a straightforward revert of the commit. Thanks Victor.

@vstinner

vstinner commented

Mar 4, 2020

Copy link Copy Markdown

Member Author

Thanks for the review @tirkarthi ;-)

@vstinner vstinner deleted the revert_u_mode branch

March 4, 2020 17:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @tirkarthi @the-knights-who-say-ni @bedevere-bot