◐ Shell
clean mode source ↗

bpo-39877: Fix PyEval_RestoreThread() for daemon threads by vstinner · Pull Request #18808 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Closed

vstinner

wants to merge 1 commit into

python:masterfrom

vstinner:daemon_thread_runtime

Closed

bpo-39877: Fix PyEval_RestoreThread() for daemon threads#18808

vstinner

wants to merge 1 commit into

python:masterfrom

vstinner:daemon_thread_runtime

Conversation

@vstinner

@vstinner vstinner commented

Mar 6, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@vstinner

vstinner commented

Mar 6, 2020

Copy link Copy Markdown

Member Author

While this change does fix https://bugs.python.org/issue39877 it leaves Python in a sad state. Daemon threads simply loop on atttempting to take the GIL, but exit_thread_if_finalizing() is not called.

I wrote a more advanced solution: PR #18811.

@vstinner vstinner closed this

Mar 6, 2020

@vstinner vstinner deleted the daemon_thread_runtime branch

March 6, 2020 17:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot