◐ Shell
clean mode source ↗

bpo-39573: Use Py_IS_TYPE to check for types by petdance · Pull Request #18809 · python/cpython

petdance

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

vstinner

merged 2 commits into

python:masterfrom

petdance:bpo-39573-E

Mar 6, 2020

Merged

bpo-39573: Use Py_IS_TYPE to check for types#18809

vstinner

merged 2 commits into

python:masterfrom

petdance:bpo-39573-E

Conversation

@petdance

@petdance petdance commented

Mar 6, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

This is an updated version of #18798. It replaces the last few places where we can use Py_IS_TYPE.

cc @vstinner

https://bugs.python.org/issue39573

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner

vstinner commented

Mar 6, 2020

Copy link Copy Markdown

Member

I had to fix a conflict. Ping me if I forget to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petdance @vstinner @the-knights-who-say-ni @bedevere-bot