◐ Shell
clean mode source ↗

bpo-30524: Fix _PyStack_UnpackDict() by vstinner · Pull Request #1886 · python/cpython

the-knights-who-say-ni

@vstinner

  • bpo-29259: Remove unused func parameter of _PyStack_UnpackDict()
  • bpo-29286: Change _PyStack_UnpackDict() prototype to be able to
    notify of failure when args is NULL. _PyStack_UnpackDict() now
    returns -1 on error.
 
* bpo-29259: Remove unused func parameter of _PyStack_UnpackDict()
* bpo-29286: Change _PyStack_UnpackDict() prototype to be able to
  notify of failure when args is NULL. _PyStack_UnpackDict() now
  returns -1 on error.

methane

serhiy-storchaka

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But would be nice to add a test.

@vstinner

LGTM. But would be nice to add a test.

I wrote unit tests for FASTCALL including a specific unit test for the datetime.datetime.now() specific case: #2022

The PR was written for master, but I will then backport it to Python 3.6.