◐ Shell
clean mode source ↗

bpo-39877: take_gil() checks tstate_must_exit() twice by vstinner · Pull Request #18888 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Closed

vstinner

wants to merge 1 commit into

python:masterfrom

vstinner:take_gil_exit2

Closed

bpo-39877: take_gil() checks tstate_must_exit() twice#18888

vstinner

wants to merge 1 commit into

python:masterfrom

vstinner:take_gil_exit2

Conversation

@vstinner

@vstinner vstinner commented

Mar 9, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

take_gil() now also checks tstate_must_exit() after acquiring the
GIL: exit the thread if Py_Finalize() has been called.

https://bugs.python.org/issue39877

 
take_gil() now also checks tstate_must_exit() after acquiring the
GIL: exit the thread if Py_Finalize() has been called.

@vstinner

vstinner commented

Mar 9, 2020

Copy link Copy Markdown

Member Author

GH Actions CI is broken. I cancelled the workflow. It didn't work. I closed/reopened the PR: GH Actions jobs are still displayed as failed and don't restart.

I created a new PR instead: PR #18890.

@vstinner

vstinner commented

Mar 9, 2020

Copy link Copy Markdown

Member Author

I created a new PR instead: PR #18890.

I merged PR #18890.

@vstinner vstinner closed this

Mar 9, 2020

@vstinner vstinner deleted the take_gil_exit2 branch

March 9, 2020 22:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot