◐ Shell
clean mode source ↗

[3.8] bpo-38576: Disallow control characters in hostnames in http.client (GH-18995) by miss-islington · Pull Request #19000 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

Mar 14, 2020

edited

Loading

Copy link Copy Markdown

Contributor

Add host validation for control characters for more CVE-2019-18348 protection.
(cherry picked from commit 9165add)

Co-authored-by: Ashwin Ramaswami aramaswamis@gmail.com

https://bugs.python.org/issue38576

Automerge-Triggered-By: @gpshead

…ythonGH-18995)

Add host validation for control characters for more CVE-2019-18348 protection.
(cherry picked from commit 9165add)

Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>

@miss-islington

Copy link Copy Markdown

Contributor Author

@epicfaace and @gpshead: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit ff69c9d into python:3.8

Mar 14, 2020

@miss-islington miss-islington deleted the backport-9165add-3.8 branch

March 14, 2020 19:13

@miss-islington

Copy link Copy Markdown

Contributor Author

@epicfaace and @gpshead: Status check is done, and it's a success ✅ .

1 similar comment

@miss-islington

Copy link Copy Markdown

Contributor Author

@epicfaace and @gpshead: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

No one assigned

Labels

type-bug

An unexpected behavior, bug, or error

type-security

A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot @epicfaace