◐ Shell
clean mode source ↗

bpo-1635741: Port _heapq module to multiphase initialization. by corona10 · Pull Request #19057 · python/cpython

corona10

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@corona10

@corona10 corona10 commented

Mar 18, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please address my minor remark.
Comment thread

Modules/_heapqmodule.c Outdated 

Co-Authored-By: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit 4657a8a into python:master

Mar 18, 2020

@corona10 corona10 deleted the bpo-1635741-_heapq branch

February 15, 2024 01:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot