bpo-1635741: Port time module to multiphase initialization (PEP 489) by phsilva · Pull Request #19107 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use mod or module would be more exact than m ;)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, please this PR as an opportunity to replace m with module ;-)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an impractical idea: Making an review robot to give some suggestions of normative problem automatically ;)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DECREF here is wrong. Replace "goto error" with "return -1" and remove the error label.
cc @corona10
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started not wanting to refactor code but looks like a good chance for more cleaning. Thanks, already changed on latest push.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this time it LGTM. Thanks ;-)
