◐ Shell
clean mode source ↗

bpo-40147: Fix a compiler warning on Windows in Python/compile.c by ZackerySpytz · Pull Request #19389 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented

Apr 6, 2020

edited

Loading

Copy link Copy Markdown

Contributor

Python\compile.c(4054,1): warning C4244: 'initializing': conversion from 'Py_ssize_t' to 'int', possible loss of data

Change the type of nkeywords to Py_ssize_t.

https://bugs.python.org/issue40147

@pablogsal pablogsal left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZackerySpytz @pablogsal @the-knights-who-say-ni @bedevere-bot