bpo-40170: Convert PyObject_IS_GC() macro to a function by shihai1991 · Pull Request #19464 · python/cpython
@shihai1991 Could you rebase the PR to pick the latest changes?
@shihai1991 Could you rebase the PR to pick the latest changes?
Got it, done ;)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hummmm, I think we still need a macro version for internal use for performance reasons. @vstinner was that your original intent?
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
Hummmm, I think we still need a macro version for internal use for performance reasons.
Right, please add a static inline function _PyObject_IS_GC() in pycore_object.h and modify gcmodule.c to use it (replace PyObject_IS_GC with _PyObject_IS_GC).
PyObject_IS_GC() function body should just call _PyObject_IS_GC().
I have made the requested changes; please review again
Thanks for making the requested changes!
@pablogsal: please review the changes made to this pull request.
Comment on lines +130 to +133
| if (PyType_IS_GC(Py_TYPE(obj))) { | ||
| return (Py_TYPE(obj)->tp_is_gc == NULL || Py_TYPE(obj)->tp_is_gc(obj)); | ||
| } | ||
| return 0; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (PyType_IS_GC(Py_TYPE(obj))) { | |
| return (Py_TYPE(obj)->tp_is_gc == NULL || Py_TYPE(obj)->tp_is_gc(obj)); | |
| } | |
| return 0; | |
| return (PyType_IS_GC(Py_TYPE(obj)) | |
| && (Py_TYPE(obj)->tp_is_gc == NULL | |
| || Py_TYPE(obj)->tp_is_gc(obj))); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code style looks more simple?
Co-Authored-By: Victor Stinner <vstinner@python.org>
Co-Authored-By: Victor Stinner <vstinner@python.org>
Thanks @shihai1991!
Thanks, folks. I learned much in this PR(especially in docs(what is user really need).