◐ Shell
clean mode source ↗

bpo-40246: Report a different error message for invalid string prefixes by lysnikolaou · Pull Request #19476 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented

Apr 11, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@lysnikolaou

Copy link Copy Markdown

Member Author

@gvanrossum gvanrossum left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One other core dev please?

@pablogsal pablogsal left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit 41d5b94 into python:master

Apr 12, 2020

@pablogsal

Copy link Copy Markdown

Member

Great job @lysnikolaou 🎉
lysnikolaou reacted with hooray emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lysnikolaou @pablogsal @gvanrossum @the-knights-who-say-ni @bedevere-bot