◐ Shell
clean mode source ↗

bpo-40334: Fix builds outside the source directory and regenerate autoconf files by pablogsal · Pull Request #19667 · python/cpython

pablogsal

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@pablogsal

@pablogsal pablogsal commented

Apr 22, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@pablogsal

Copy link Copy Markdown

Member Author

The extra diff is the result of running autoreconf

@pablogsal pablogsal requested a review from vstinner

April 22, 2020 23:46

@ned-deily ned-deily left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pablogsal pablogsal merged commit a25f3c4 into python:master

Apr 23, 2020

@pablogsal pablogsal deleted the fix_outsidedir branch

April 23, 2020 00:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @ned-deily @the-knights-who-say-ni @bedevere-bot