bpo-40217: Clean code in PyType_FromSpec_Alloc and add NEWS entry by pablogsal · Pull Request #19733 · python/cpython
Conversation
Some minor cleanups were missing before #19414 was merged
| if (obj == NULL) { | ||
| return PyErr_NoMemory(); | ||
|
|
||
| obj = obj; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to keep this instruction? I love it :-D (I'm kidding you, please remove it!)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add some volatile 😉
Co-Authored-By: Victor Stinner <vstinner@python.org>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters