◐ Shell
clean mode source ↗

bpo-40334: Fix shifting of nested fstrings by lysnikolaou · Pull Request #19771 · python/cpython

lysnikolaou

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented

Apr 28, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

JoinedStrs and FormattedValues also need to be shifted, in order
to correctly compute the location of nested fstrings.

Closes we-like-parsers#114.

https://bugs.python.org/issue40334

 
`JoinedStr`s and `FormattedValue`s also need to be shifted, in order
to correctly compute the location of nested fstrings.

Closes we-like-parsers#114.

@pablogsal

Copy link Copy Markdown

Member

I don't understand why Azure keeps failing :S

@pablogsal pablogsal closed this

Apr 29, 2020

@pablogsal pablogsal reopened this

Apr 29, 2020

@pablogsal pablogsal merged commit 37af21b into python:master

Apr 29, 2020

@lysnikolaou lysnikolaou deleted the fix-nested-fstring-shifting branch

April 29, 2020 07:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Column offsets in nested f-string expressions are wrong

4 participants

@lysnikolaou @pablogsal @the-knights-who-say-ni @bedevere-bot