bpo-40334: Simplify type handling in the PEG c_generator by pablogsal · Pull Request #19818 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Conversation
Member
Follow up of #19775. With this PR almost all the type-deducing code in add_var can be eliminated :)
As a bonus, this PR eliminates some extra void* in the generated code :)
gvanrossum
approved these changes
gvanrossum
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent insight!
lysnikolaou
approved these changes
lysnikolaou
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Truly great improvements, this and #19775.
gvanrossum
commented
Apr 30, 2020
gvanrossum commented
Member
There's a conflict. Looks like you have to run make regen-pegen again.
d78c9f5 to
c2617bf
Compare
c2617bf to
bda6169
Compare
b796b3f
into
python:master
pablogsal
commented
May 1, 2020
pablogsal commented
Member Author
Thanks both for the review! 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
