◐ Shell
clean mode source ↗

Revert "bpo-29587: Enable implicit exception chaining with gen.throw()" by vstinner · Pull Request #19821 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@vstinner

@vstinner vstinner commented

Apr 30, 2020

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@gvanrossum gvanrossum left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go ahead with the revert. I have no idea what causes the segfaults and no way to repro (all I have is a Mac).

@vstinner

Copy link Copy Markdown

Member Author

@gvanrossum: I prepared this PR to repair buildbots if you are unavailable to investigate https://bugs.python.org/issue29587 bug. I'm unavailable right now and I would prefer to move back buildbot to green ASAP :-)

@vstinner vstinner merged commit 3c7f9db into master

Apr 30, 2020

@vstinner vstinner deleted the revert-19811-fix-issue-29587 branch

April 30, 2020 20:44

@bedevere-bot

Copy link Copy Markdown

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

@vstinner

Copy link Copy Markdown

Member Author

Please go ahead with the revert.

Ok, done.

cjerdonek reacted with thumbs up emoji

@gvanrossum

gvanrossum commented

Apr 30, 2020

via email

Copy link Copy Markdown

Member

So I could use some help with fixing this. But no hurry. @cjerdonek? -- --Guido (mobile)

@cjerdonek

Copy link Copy Markdown

Member

Thanks, @gvanrossum and @vstinner. I can reply on the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @bedevere-bot @gvanrossum @cjerdonek @the-knights-who-say-ni