Revert "bpo-29587: Enable implicit exception chaining with gen.throw()" by vstinner · Pull Request #19821 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Conversation
Member
vstinner
requested a review
from 1st1
as a code owner
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
gvanrossum
approved these changes
gvanrossum
left a comment
gvanrossum
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go ahead with the revert. I have no idea what causes the segfaults and no way to repro (all I have is a Mac).
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
vstinner
commented
Apr 30, 2020
vstinner commented
Member Author
@gvanrossum: I prepared this PR to repair buildbots if you are unavailable to investigate https://bugs.python.org/issue29587 bug. I'm unavailable right now and I would prefer to move back buildbot to green ASAP :-)
vstinner
merged commit
3c7f9db
into
master
vstinner
deleted the
revert-19811-fix-issue-29587
branch
bedevere-bot
commented
Apr 30, 2020
bedevere-bot commented
@vstinner: Please replace # with GH- in the commit message next time. Thanks!
bedevere-bot
removed
the
awaiting merge
label
vstinner
commented
Apr 30, 2020
vstinner commented
Member Author
Please go ahead with the revert.
Ok, done.
Member
So I could use some help with fixing this. But no hurry. @cjerdonek? -- --Guido (mobile)
cjerdonek
commented
Apr 30, 2020
cjerdonek commented
Member
Thanks, @gvanrossum and @vstinner. I can reply on the original issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment