bpo-40334: Refactor lambda_parameters similar to parameters by gvanrossum · Pull Request #19830 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Conversation
Member
Figured I might as well make the two very similar. (Please double-check that I renamed everything everywhere. :-)
gvanrossum
added
the
skip news
label
gvanrossum
requested a review
from lysnikolaou
gvanrossum
requested a review
from pablogsal
as a code owner
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
gvanrossum added 2 commits
pablogsal
commented
May 1, 2020
pablogsal commented
Member
Seems that we have some merge conflicts... could you regenerate parse.c?
lysnikolaou
approved these changes
lysnikolaou
left a comment
lysnikolaou
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I said in #19780, the whole parameters situation is much much better now. Thanks!
pablogsal
approved these changes
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
pablogsal
merged commit
3941d97
into
master
pablogsal
deleted the
refactor-lambda-parameters
branch
bedevere-bot
removed
the
awaiting merge
label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment