bpo-29587: Remove the exc_value NULL check in _gen_throw() by cjerdonek · Pull Request #19877 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Conversation
Member
This is another follow-up to PR #19823, removing the check that exc_value isn't NULL prior to calling _PyErr_ChainExceptions(). This makes it so that exception chaining can occur in more cases.
cjerdonek added 2 commits
cjerdonek
added
the
skip news
label
cjerdonek
requested a review
from 1st1
as a code owner
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
gvanrossum
approved these changes
gvanrossum
left a comment
gvanrossum
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good luck!
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
cjerdonek
commented
May 3, 2020
cjerdonek commented
Member Author
Thanks! :) I'll be posting a comment on the issue with what I found..
cjerdonek
merged commit
21893fb
into
python:master
bedevere-bot
removed
the
awaiting merge
label
cjerdonek
deleted the
issue-29587-allow-null-values
branch
This was referenced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment