◐ Shell
clean mode source ↗

bpo-29587: Remove the exc_value NULL check in _gen_throw() by cjerdonek · Pull Request #19877 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@cjerdonek

@cjerdonek cjerdonek commented

May 3, 2020

edited

Loading

Copy link Copy Markdown

Member

This is another follow-up to PR #19823, removing the check that exc_value isn't NULL prior to calling _PyErr_ChainExceptions(). This makes it so that exception chaining can occur in more cases.

https://bugs.python.org/issue29587

@gvanrossum gvanrossum left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck!

@cjerdonek

Copy link Copy Markdown

Member Author

Thanks! :) I'll be posting a comment on the issue with what I found..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cjerdonek @gvanrossum @the-knights-who-say-ni @bedevere-bot