bpo-40596: Fix str.isidentifier() for non-canonicalized strings containing non-BMP characters on Windows. by serhiy-storchaka · Pull Request #20035 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Conversation
…ining non-BMP characters on Windows.
| { | ||
| /* Since there is no way to return an error from PyUnicode_IsIdentifier() | ||
| we have to call PyUnicode_READY() to ensure that the string object is | ||
| in the "canonical" representation. */ |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this comment is worth it. It's something usual to report an error when a function fails. All functions in this file does that. I suggest to remove the comment.
Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters