◐ Shell
clean mode source ↗

[3.8] bpo-25872: Fix KeyError using linecache from multiple threads (GH-20079) by miss-islington · Pull Request #20079 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

May 13, 2020

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

The crash that this fixes occurs when using traceback and other modules from multiple threads;
del cache[filename] can raise a KeyError.
(cherry picked from commit d72ea60)

Co-authored-by: Michael Graczyk mgraczyk@users.noreply.github.com

https://bugs.python.org/issue25872

…onGH-18007)

The crash that this fixes occurs when using traceback and other modules from multiple threads;
del cache[filename] can raise a KeyError.
(cherry picked from commit d72ea60)

Co-authored-by: Michael Graczyk <mgraczyk@users.noreply.github.com>

@miss-islington

Copy link Copy Markdown

Contributor Author

@mgraczyk and @akuchling: Status check is done, and it's a failure ❌ .

2 similar comments

@miss-islington

Copy link Copy Markdown

Contributor Author

@mgraczyk and @akuchling: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link Copy Markdown

Contributor Author

@mgraczyk and @akuchling: Status check is done, and it's a failure ❌ .

@akuchling akuchling self-assigned this

May 14, 2020

@akuchling akuchling changed the title [3.8] issue-25872: Fix KeyError using linecache from multiple threads (GH-18007) [3.8] bpo-25872: Fix KeyError using linecache from multiple threads (GH-20079)

May 14, 2020

@miss-islington

Copy link Copy Markdown

Contributor Author

@miss-islington: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link Copy Markdown

Contributor Author

@miss-islington: Status check is done, and it's a success ✅ .

@akuchling akuchling closed this

May 14, 2020

@miss-islington miss-islington deleted the backport-d72ea60-3.8 branch

May 14, 2020 19:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@akuchling akuchling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @akuchling @the-knights-who-say-ni @bedevere-bot @mgraczyk