◐ Shell
clean mode source ↗

[3.8] bpo-40055: test_distutils leaves warnings filters unchanged (GH-20095) by miss-islington · Pull Request #20109 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

May 15, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

distutils.tests now saves/restores warnings filters to leave them
unchanged. Importing tests imports docutils which imports
pkg_resources which adds a warnings filter.
(cherry picked from commit 6e57237)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue40055

 
…-20095)

distutils.tests now saves/restores warnings filters to leave them
unchanged. Importing tests imports docutils which imports
pkg_resources which adds a warnings filter.
(cherry picked from commit 6e57237)

Co-authored-by: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 4e6545b into python:3.8

May 15, 2020

@miss-islington miss-islington deleted the backport-6e57237-3.8 branch

May 15, 2020 16:25

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot