bpo-40217: Ensure Py_VISIT(Py_TYPE(self)) is always called for PyType_FromSpec types (reverts GH-19414) by pablogsal · Pull Request #20264 · python/cpython

pablogsal

pablogsal marked this pull request as ready for review

May 23, 2020 00:22

pablogsal changed the title ~~bpo-40217: Revert "Ensure Py_VISIT(Py_TYPE(self)) is always called for PyType_FromSpec types (GH-19414)"~~ bpo-40217: Rework "Ensure Py_VISIT(Py_TYPE(self)) is always called for PyType_FromSpec types (GH-19414)"

May 23, 2020

If the base is a heap type, the responsibility to visit
Py_TYPE(self) is delegated to the base's tp_traverse.

encukou changed the title ~~bpo-40217: Rework "Ensure Py_VISIT(Py_TYPE(self)) is always called for PyType_FromSpec types (GH-19414)"~~ bpo-40217: Ensure Py_VISIT(Py_TYPE(self)) is always called for PyType_FromSpec types (reverts GH-19414)

May 27, 2020

miss-islington added a commit that referenced this pull request

May 28, 2020

…_FromSpec types (reverts GH-19414) (GH-20264)

Heap types now always visit the type in tp_traverse. See added docs for details.

This reverts commit 0169d30.

Automerge-Triggered-By: @encukou
(cherry picked from commit 1cf15af)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>