bpo-39783: Optimize contruction of Path and PurePath objects by remilapeyre · Pull Request #20288 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Conversation
bpo-39782: Optimize contruction of Path and PurePath objects
bpo-39783: Optimize contruction of Path and PurePath objects
Could this be implemented in _from_parts() to avoid doubling up the code?
Could this be implemented in
_from_parts()to avoid doubling up the code?
Yes, thanks!
|
|
||
| @classmethod | ||
| def _from_parts(cls, args, init=True): | ||
| def _from_parts(cls, args, kwargs=None, *, init=True): |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like kwargs is not needed as it's not used anywhere?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been removed on main, you have a merge conflict now.
Closing - see rationale in issue. Thanks all the same for the patch.