◐ Shell
clean mode source ↗

[3.9] bpo-40246: Fix test_fstring when run with the old parser by lysnikolaou · Pull Request #20402 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented

May 25, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@pablogsal

Copy link Copy Markdown

Member

@lysnikolaou This does not affect 3.10?

@lysnikolaou

Copy link Copy Markdown

Member Author

It currently does, but I don't think we need to fix that, since the old parser will be removed some time before the 3.10 release.
pablogsal reacted with thumbs up emoji

@pablogsal pablogsal merged commit 6cb0ad2 into python:3.9

May 26, 2020

@pablogsal

Copy link Copy Markdown

Member

It currently does, but I don't think we need to fix that, since the old parser will be removed some time before the 3.10 release.

💥 I am waiting to unleash the destruction PR 😉
lysnikolaou reacted with laugh emoji

@lysnikolaou

Copy link Copy Markdown

Member Author

Looking forward to that.

@lysnikolaou lysnikolaou deleted the fix-test-fstring branch

May 26, 2020 00:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lysnikolaou @pablogsal @the-knights-who-say-ni @bedevere-bot