◐ Shell
clean mode source ↗

bpo-37999: Simplify the conversion code for %c, %d, %x, etc. by serhiy-storchaka · Pull Request #20437 · python/cpython

serhiy-storchaka

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented

May 26, 2020

•

edited

Loading

Copy link Copy Markdown

Member

Since PyLong_AsLong() no longer use __int__, explicit call of PyNumber_Index() before it is no longer needed.

https://bugs.python.org/issue37999

 
Since PyLong_AsLong() no longer use __int__, explicit call
of PyNumber_Index() before it is no longer needed.

@mdickinson mdickinson left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdickinson mdickinson mdickinson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @mdickinson @the-knights-who-say-ni @bedevere-bot