◐ Shell
clean mode source ↗

Revert "bpo-32604: PEP 554 for use in test suite (GH-19985)" by pablogsal · Pull Request #20465 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@pablogsal

@pablogsal pablogsal commented

May 27, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree with https://bugs.python.org/issue32604#msg370130 to revert.

@nanjekyejoannah

Copy link Copy Markdown

Contributor

You can revert until I look probably this weekend

@vstinner vstinner merged commit 7d80b35 into python:master

May 27, 2020

@bedevere-bot

Copy link Copy Markdown

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

@vstinner

Copy link Copy Markdown

Member

You can revert until I look probably this weekend

Ok, thanks @nanjekyejoannah. I merged the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@nanjekyejoannah nanjekyejoannah nanjekyejoannah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @nanjekyejoannah @bedevere-bot @vstinner @the-knights-who-say-ni