◐ Shell
clean mode source ↗

bpo-40862: Raise TypeError when const is given to argparse.BooleanOptionalAction by remilapeyre · Pull Request #20623 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@remilapeyre

@remilapeyre remilapeyre commented

Jun 4, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

@hauntsaninja hauntsaninja left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm apart from comment nit
Comment thread

Lib/test/test_argparse.py Outdated 

Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>

@rhettinger rhettinger self-assigned this

Jun 5, 2020

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @remilapeyre for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

Copy link Copy Markdown

GH-20664 is a backport of this pull request to the 3.9 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees

@rhettinger rhettinger

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@remilapeyre @miss-islington @bedevere-bot @rhettinger @hauntsaninja @the-knights-who-say-ni